Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make common-utils core compatible after core #9082 #507

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Aug 14, 2023

Description

make common-utils core compatible after core #9082

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #507 (a5e0aac) into main (9d14a6d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #507   +/-   ##
=========================================
  Coverage     74.48%   74.48%           
  Complexity      859      859           
=========================================
  Files           129      129           
  Lines          5597     5597           
  Branches        684      684           
=========================================
  Hits           4169     4169           
  Misses         1124     1124           
  Partials        304      304           
Files Changed Coverage Δ
...search/commons/alerting/AlertingPluginInterface.kt 56.79% <ø> (ø)
...mons/notifications/NotificationsPluginInterface.kt 94.87% <ø> (ø)
...earch/commons/notifications/action/BaseResponse.kt 66.66% <ø> (ø)
...h/commons/notifications/model/NotificationEvent.kt 86.04% <ø> (ø)
...rg/opensearch/commons/utils/SecureClientWrapper.kt 8.88% <ø> (ø)

@sbcd90 sbcd90 merged commit fad4525 into opensearch-project:main Aug 15, 2023
8 checks passed
@zhichao-aws
Copy link
Member

Kind reminder: this PR should also be backported to 2.x. opensearch-project/OpenSearch#9352

opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 17, 2023
Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit fad4525)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep pushed a commit that referenced this pull request Aug 17, 2023
(cherry picked from commit fad4525)

Signed-off-by: Subhobrata Dey <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…h-project#510)

(cherry picked from commit fad4525)

Signed-off-by: Subhobrata Dey <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants