Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.x - add auditDelegateMonitorAlerts flag (#476) #477

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Backport 2.x - add auditDelegateMonitorAlerts flag (#476) #477

merged 1 commit into from
Jul 11, 2023

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Jul 10, 2023

Backports #476

  • add auditDelegateMonitorAlerts flag

  • add audit state check in error alert validation

  • add test to verify workflow with auditDelegateMonitor flag null


Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* add auditDelegateMonitorAlerts flag

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add audit state check in error alert validation

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add test to verify workflow with auditDelegateMonitor flag null

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #477 (5b27aa9) into 2.x (1800974) will increase coverage by 0.60%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##                2.x     #477      +/-   ##
============================================
+ Coverage     72.16%   72.77%   +0.60%     
- Complexity      829      837       +8     
============================================
  Files           129      129              
  Lines          5562     5575      +13     
  Branches        682      683       +1     
============================================
+ Hits           4014     4057      +43     
+ Misses         1252     1216      -36     
- Partials        296      302       +6     
Impacted Files Coverage Δ
...lin/org/opensearch/commons/alerting/model/Alert.kt 73.55% <66.66%> (+0.06%) ⬆️
.../org/opensearch/commons/alerting/model/Workflow.kt 82.20% <90.90%> (+0.91%) ⬆️
...ommons/alerting/action/GetWorkflowAlertsRequest.kt 95.45% <100.00%> (+0.45%) ⬆️

... and 2 files with indirect coverage changes

@eirsep eirsep merged commit 90bea0c into 2.x Jul 11, 2023
11 of 12 checks passed
@eirsep eirsep added the backport 2.9 backport PR to 2.9 label Jul 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
* add auditDelegateMonitorAlerts flag

* add audit state check in error alert validation

* add test to verify workflow with auditDelegateMonitor flag null

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 90bea0c)
AWSHurneyt pushed a commit that referenced this pull request Jul 11, 2023
* add auditDelegateMonitorAlerts flag

* add audit state check in error alert validation

* add test to verify workflow with auditDelegateMonitor flag null

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 90bea0c)

Co-authored-by: Surya Sashank Nistala <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…rch-project#477)

* add auditDelegateMonitorAlerts flag



* add audit state check in error alert validation



* add test to verify workflow with auditDelegateMonitor flag null



---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.9 backport PR to 2.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants