Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common utils to support Microsoft teams in notifications #428

Merged
merged 12 commits into from
Aug 18, 2023

Conversation

zhichao-aws
Copy link
Member

@zhichao-aws zhichao-aws commented May 15, 2023

Description

Add common utils to support Microsoft teams in notifications plugin

Issues Resolved

opensearch-project/notifications#585

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #428 (46e3deb) into main (fad4525) will increase coverage by 0.12%.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##               main     #428      +/-   ##
============================================
+ Coverage     74.48%   74.60%   +0.12%     
- Complexity      859      868       +9     
============================================
  Files           129      130       +1     
  Lines          5597     5632      +35     
  Branches        684      689       +5     
============================================
+ Hits           4169     4202      +33     
  Misses         1124     1124              
- Partials        304      306       +2     
Files Changed Coverage Δ
...nsearch/commons/notifications/model/EventStatus.kt 81.15% <0.00%> (-1.20%) ⬇️
...arch/commons/notifications/model/MicrosoftTeams.kt 96.66% <96.66%> (ø)
...ensearch/commons/notifications/model/ConfigType.kt 100.00% <100.00%> (ø)
...notifications/model/config/ConfigDataProperties.kt 77.77% <100.00%> (+1.77%) ⬆️

@zhichao-aws
Copy link
Member Author

zhichao-aws commented May 15, 2023

@zhichao-aws zhichao-aws marked this pull request as draft May 17, 2023 01:58
@zhichao-aws zhichao-aws marked this pull request as ready for review August 7, 2023 03:54
@zhichao-aws
Copy link
Member Author

Hi team, please help review and add backport 2.x label.

@zhichao-aws
Copy link
Member Author

@opensearch-project/common-utils Could someone help review this PR? Thanks!

@zhichao-aws
Copy link
Member Author

Hi @lezzago @qreshi @AWSHurneyt , you contributed many codes to the notifications plugin and are familiar with it. Could you please take a look and help review this PR? Thanks!

@lezzago
Copy link
Member

lezzago commented Aug 15, 2023

@zhichao-aws has this been tested locally with the Notification plugin to ensure the new channel works?

@zhichao-aws
Copy link
Member Author

@lezzago Yes, we test the function locally and here are some screenshots:

image
image
image

@Hailong-am
Copy link
Contributor

@AWSHurneyt @lezzago could you help to merge it and add backport 2.x label?

@AWSHurneyt AWSHurneyt merged commit bae1bee into opensearch-project:main Aug 18, 2023
8 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 18, 2023
* Added common utils for microsoft teams

Signed-off-by: danielkyalo599 <[email protected]>

* Added configType ,eventstatus,configDataProperties and msTeams files

Signed-off-by: dankyalo599 <[email protected]>

* Added ConfigType,EventStatus,ConfigDataProperties and MicrosoftTeams

Signed-off-by: dankyalo599 <[email protected]>

* fix build

Signed-off-by: zhichao-aws <[email protected]>

* fix build, add more test

Signed-off-by: zhichao-aws <[email protected]>

* change strings import

Signed-off-by: zhichao-aws <[email protected]>

* fix after core

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: danielkyalo599 <[email protected]>
Signed-off-by: dankyalo599 <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Co-authored-by: danielkyalo599 <[email protected]>
(cherry picked from commit bae1bee)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bowenlan-amzn pushed a commit that referenced this pull request Aug 18, 2023
* Added common utils for microsoft teams



* Added configType ,eventstatus,configDataProperties and msTeams files



* Added ConfigType,EventStatus,ConfigDataProperties and MicrosoftTeams



* fix build



* fix build, add more test



* change strings import



* fix after core



---------





(cherry picked from commit bae1bee)

Signed-off-by: danielkyalo599 <[email protected]>
Signed-off-by: dankyalo599 <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: danielkyalo599 <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…project#428) (opensearch-project#512)

* Added common utils for microsoft teams



* Added configType ,eventstatus,configDataProperties and msTeams files



* Added ConfigType,EventStatus,ConfigDataProperties and MicrosoftTeams



* fix build



* fix build, add more test



* change strings import



* fix after core



---------





(cherry picked from commit bae1bee)

Signed-off-by: danielkyalo599 <[email protected]>
Signed-off-by: dankyalo599 <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: danielkyalo599 <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants