Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ensure integ tests run with security after plugin rename #1025

Closed
cwperks opened this issue Sep 7, 2023 · 2 comments
Closed

[BUG] Ensure integ tests run with security after plugin rename #1025

cwperks opened this issue Sep 7, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@cwperks
Copy link
Member

cwperks commented Sep 7, 2023

Description

The security test workflow is currently skipping running tests with security quietly. See the example from the latest commit on main here where Run AD Test is skipped.

The expressions to set values in the github workflow are not getting executed as expected after the plugin was renamed to time-series-analytics

Specifically these lines:

plugin=`basename $(ls build/distributions/*.zip)`
version=`echo $plugin|awk -F- '{print $4}'| cut -d. -f 1-3`
plugin_version=`echo $plugin|awk -F- '{print $4}'| cut -d. -f 1-4`
qualifier=`echo $plugin|awk -F- '{print $5}'| cut -d. -f 1-1`
if $qualifier!=SNAPSHOT
then
  docker_version=$version-$qualifier
else
  docker_version=$version
fi

echo $plugin|awk -F- '{print $4}' is getting evaluated to analytics instead of 3.0.0.0 because of the extra hyphen in

opensearch-time-series-analytics-3.0.0.0-SNAPSHOT.zip

compared to

opensearch-anomaly-detection-3.0.0.0-SNAPSHOT.zip
@kaituo
Copy link
Collaborator

kaituo commented Sep 21, 2023

@cwperks Can we close the issue? It seems #1023 have fixed it.

@cwperks
Copy link
Member Author

cwperks commented Sep 21, 2023

Yes this can be closed. Closing now.

@cwperks cwperks closed this as completed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants