Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add a flag in QueryShardContext to differentiate inner hit query #16620

Merged
merged 2 commits into from
Nov 13, 2024
Merged

[Backport 2.x] Add a flag in QueryShardContext to differentiate inner hit query #16620

merged 2 commits into from
Nov 13, 2024
+16 −0

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c9edb48 from #16600.

@github-actions
Add a flag in QueryShardContext to differentiate between a normal que…
19d012e 
…ry and an inner hit query (#16600)

Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit c9edb48)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 19d012e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 11, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 19d012e:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@heemin32
Copy link
Contributor

Flaky test failed.

#14327

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 19d012e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 12, 2024
Open
@heemin32
Copy link
Contributor

@msfroh could you re-trigger the test?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 19d012e: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (94da76d) to head (c83a191).
Report is 9 commits behind head on 2.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16620      +/-   ##
============================================
+ Coverage     71.72%   71.86%   +0.14%     
- Complexity    65300    65389      +89     
============================================
  Files          5314     5314              
  Lines        305140   305171      +31     
  Branches      44458    44464       +6     
============================================
+ Hits         218859   219314     +455     
+ Misses        68025    67504     -521     
- Partials      18256    18353      +97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c83a191: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 13, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for c83a191: SUCCESS

@dbwiddis dbwiddis merged commit 77231fb into 2.x Nov 13, 2024
39 checks passed
@dbwiddis dbwiddis deleted the backport/backport-16600-to-2.x branch November 13, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@msfroh msfroh msfroh approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heemin32 @msfroh @dbwiddis