-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add success and failure count OTel metrics for async shard fetch #15976
Add success and failure count OTel metrics for async shard fetch #15976
Conversation
❕ Gradle check result for 065ba11: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
server/src/main/java/org/opensearch/gateway/AsyncShardFetchCache.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/AsyncShardFetchCache.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 48e9fa2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
48e9fa2
to
cfb40f1
Compare
❌ Gradle check result for cfb40f1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
failing tests: #14331 - ShardIndexingPressureSettingsIT verified these 4 tests have showed up in flaky test report |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15976 +/- ##
============================================
- Coverage 72.00% 71.98% -0.02%
- Complexity 64487 64512 +25
============================================
Files 5288 5288
Lines 301419 301438 +19
Branches 43549 43552 +3
============================================
- Hits 217026 216994 -32
- Misses 66587 66650 +63
+ Partials 17806 17794 -12 ☔ View full report in Codecov by Sentry. |
9485876
to
bd80ae6
Compare
Signed-off-by: Rahul Karajgikar <[email protected]>
Signed-off-by: Rahul Karajgikar <[email protected]>
Signed-off-by: Rahul Karajgikar <[email protected]>
Signed-off-by: Rahul Karajgikar <[email protected]>
Signed-off-by: Rahul Karajgikar <[email protected]>
Signed-off-by: Rahul Karajgikar <[email protected]>
Signed-off-by: Rahul Karajgikar <[email protected]>
Signed-off-by: Rahul Karajgikar <[email protected]>
574b12a
to
a4ec644
Compare
❌ Gradle check result for a4ec644: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rahul Karajgikar <[email protected]>
8ddb3ee
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15976-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ddb3eeee00978913fedd5aa49a84e718538ddae
# Push it to GitHub
git push --set-upstream origin backport/backport-15976-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…nsearch-project#15976) Signed-off-by: Rahul Karajgikar <[email protected]> (cherry picked from commit 8ddb3ee)
raised manual backport: https://github.com/opensearch-project/OpenSearch/pull/16130/files |
) (#16130) Signed-off-by: Rahul Karajgikar <[email protected]> (cherry picked from commit 8ddb3ee)
…nsearch-project#15976) Signed-off-by: Rahul Karajgikar <[email protected]>
…nsearch-project#15976) Signed-off-by: Rahul Karajgikar <[email protected]>
…nsearch-project#15976) Signed-off-by: Rahul Karajgikar <[email protected]>
…nsearch-project#15976) Signed-off-by: Rahul Karajgikar <[email protected]>
…nsearch-project#15976) Signed-off-by: Rahul Karajgikar <[email protected]>
Description
This change adds failure count and success count OTel metrics for async shard fetch
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.