-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URI path filtering support in cluster stats API #15938
URI path filtering support in cluster stats API #15938
Conversation
❌ Gradle check result for 1a7b37b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
1a7b37b
to
f95c505
Compare
❌ Gradle check result for f95c505: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f95c505
to
2263cf0
Compare
❌ Gradle check result for 2263cf0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2263cf0
to
0038530
Compare
❌ Gradle check result for 0038530: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/action/admin/cluster/stats/ClusterStatsIndices.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/admin/cluster/stats/ClusterStatsRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/admin/cluster/stats/ClusterStatsResponse.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/admin/cluster/stats/ClusterStatsIndices.java
Show resolved
Hide resolved
0038530
to
f55c09c
Compare
❌ Gradle check result for da52aeb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test: #15812 |
❌ Gradle check result for be9e6cd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Swetha Guptha <[email protected]>
be9e6cd
to
302e7ec
Compare
@SwethaGuptha please add changelog for it |
we will need documentation PR and Rest API spec PR as well for this change. |
Signed-off-by: Swetha Guptha <[email protected]>
Raised PR for both of them. |
Signed-off-by: shwetathareja <[email protected]>
1982427
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15938-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 19824275fe78014249143724c5b84a6211e6e642
# Push it to GitHub
git push --set-upstream origin backport/backport-15938-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…5938) * URI path filtering support in cluster stats API Signed-off-by: Swetha Guptha <[email protected]> (cherry picked from commit 1982427) Signed-off-by: Swetha Guptha <[email protected]>
…5938) * URI path filtering support in cluster stats API Signed-off-by: Swetha Guptha <[email protected]> (cherry picked from commit 1982427) Signed-off-by: Swetha Guptha <[email protected]>
…5938) * URI path filtering support in cluster stats API Signed-off-by: Swetha Guptha <[email protected]> (cherry picked from commit 1982427) Signed-off-by: Swetha Guptha <[email protected]>
* URI path filtering support in cluster stats API (cherry picked from commit 1982427) Signed-off-by: Swetha Guptha <[email protected]>
Description
Introduced new URI paths to fetch specific information from _cluster/stats without having to fetch the entire stats that will benefit the API's performance. Motivation from #14447. The _cluster/stats API primarily comprises of nodes stats and indices stats, with the new URI paths, properties of these stats objects are flattened and clients can request for specific information.
URI paths introduced:
Metrics supported:
os, process, jvm, fs, plugins, ingest, network_types, discovery_types, packaging_types, indices, _all
Index Metrics supported:
shards, docs, store , fielddata, query_cache, completion, segments, analysis, mappings, _all
Example REST request formats to exclude the information for
Request for fetching specific index stats properties only:
Request for fetching specific node stats properties only:
Request for fetching specific node stats and indices state properties:
If a random metric is requested, exception is thrown:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.