Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Validation of Peer Recovery esp. Translog replay part #3946

Closed
ashking94 opened this issue Jul 19, 2022 · 2 comments
Closed
Labels
enhancement Enhancement or improvement to existing feature or request untriaged

Comments

@ashking94
Copy link
Member

Is your feature request related to a problem? Please describe.
As part of remote store work, we will start storing the translogs remotely. Peer recovery has a stage where it downloads the translogs from the primary and replays it on the target shard. Given translogs are not stored locally, we would need to make use of abstractions created in #3945.

Describe the solution you'd like
This story is to make sure that PEER recovery works as expected when the remote store has been brought to working state.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@ashking94 ashking94 added enhancement Enhancement or improvement to existing feature or request untriaged labels Jul 19, 2022
@Bukhtawar
Copy link
Collaborator

Peer recovery uses PRRL(peer recovery retention leases) on the LuceneChangesSnapshot so the translog files aren't involved. Do you still want to pursue this?

@ashking94
Copy link
Member Author

Ah, Ok. Then we could have a common issue for keeping checklist of what all things must be validated as part of this effort. We can create a generic issue if it does not exist already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request untriaged
Projects
None yet
Development

No branches or pull requests

2 participants