You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Following this comment on #8060: Discover infinite scrolling queries are currently hardcoded to assume that for every available query language, running it with no limit configured will truncate the records after exactly 500 records. This is true for DQL and Lucene queries, but not for PPL or SQL, which have default limits of 200.
To Reproduce
Steps to reproduce the behavior:
Create an index that has more than 500 records, using e.g. this docker-compose to generate data.
Enable query enhancements
Run a DQL query on the index -- notice that there's a truncated search callout indicating the records are truncated
Do the same thing with a PPL query, where the default limit is 200
Observe there's no such callout
Expected behavior
Depending on the selected language, there should be a callout for either 200 or 500 records as a default limit (possibly even pulling from a configured setting somewhere). It's maybe not sufficient to add the callout for 200 or 500 both with the same hardcoding, as this would lead to cases where it says it's truncated when more data is still being pulled (albeit only for some intermediate render steps).
It's worth noting that due to this hardcoded check, the callout also shows up if you run a SQL query with LIMIT 500 or PPL with HEAD 500 as the returned records matches the expected truncation threshold, when no truncation is occurring. These callouts ideally shouldn't show up if the query returns exactly 200 or 500 records without truncation (although knowing this ahead of time may be equivalent to the halting problem).
OpenSearch Version
2.16.0
Dashboards Version
Current main, pre-2.17 but post-2.16
Plugins
Observability, Reporting, Query Workbench. The SQL plugin on the backend is important.
Screenshots
See above.
Host/Environment (please complete the following information):
OS: Mac OS
Browser and version: Firefox 129.0.2
Additional context
N/A
The text was updated successfully, but these errors were encountered:
Describe the bug
Following this comment on #8060: Discover infinite scrolling queries are currently hardcoded to assume that for every available query language, running it with no limit configured will truncate the records after exactly 500 records. This is true for DQL and Lucene queries, but not for PPL or SQL, which have default limits of 200.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Depending on the selected language, there should be a callout for either
200
or500
records as a default limit (possibly even pulling from a configured setting somewhere). It's maybe not sufficient to add the callout for200
or500
both with the same hardcoding, as this would lead to cases where it says it's truncated when more data is still being pulled (albeit only for some intermediate render steps).It's worth noting that due to this hardcoded check, the callout also shows up if you run a SQL query with
LIMIT 500
or PPL withHEAD 500
as the returned records matches the expected truncation threshold, when no truncation is occurring. These callouts ideally shouldn't show up if the query returns exactly 200 or 500 records without truncation (although knowing this ahead of time may be equivalent to the halting problem).OpenSearch Version
2.16.0
Dashboards Version
Current
main
, pre-2.17 but post-2.16Plugins
Observability, Reporting, Query Workbench. The SQL plugin on the backend is important.
Screenshots
See above.
Host/Environment (please complete the following information):
Additional context
N/A
The text was updated successfully, but these errors were encountered: