If POOL is a hostname or host:port then use it as a central manager as opposed to bailing out #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s opposed to bailing out We don't specify a separate CCB_ADDRESS in that case; also we disable remote syslog. Also toss in a special case that if POOL is "ospool" then we choose prod-ospool or itb-ospool depending on $ITB. I like this better than having that behavior be implicit if POOL is blank. (SOFTWARE-5383)
matyasselmeci
force-pushed
the
pr/custom-pool.SOFTWARE-5383
branch
from
297776f
to
2349a63
Compare
|
I'm in support. This makes the IceCube config easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't specify a separate CCB_ADDRESS in that case; also we disable remote syslog. Also toss in a special case that if POOL is "ospool" then we choose prod-ospool or itb-ospool depending on $ITB. I like this better than having that behavior be implicit if POOL is blank.
(SOFTWARE-5383)