PowerMockito doThrow(Throwable).when(Class, String, any()) not converted to Mockito single argument when

[anand188]

I am using

org.openrewrite.maven rewrite-maven-plugin 5.39.2 true org.openrewrite.java.testing.mockito.ReplacePowerMockito org.openrewrite.recipe rewrite-testing-frameworks 2.17.0

Is your project a single module or a multi-module project? Yes

Can you share your configuration so that we can rule out any configuration issues?

Is your project public? If so, can you share a link to it? no

[timtebeek]

Hi @anand188 ; There's been a recent fix to the Powermock migration recipe in:

• PowerMockitoMockStaticToMockito duplicates variables and methods when static nested class is involved #588

Would you mind trying again with the latest version?
https://github.com/openrewrite/rewrite-testing-frameworks/releases/tag/v2.17.1

Beyond that your question lacks the details we need to replicate the issue;
if the problems persist with the latest version I suggest you create a minimal reproducer.

[anand188]

@timtebeek tried 2.17.1 also doesn't seem to address the issue same not completing migrating.

[anand188]

PowerMockito.doThrow(new IllegalArgumentException()).when( xx.class,"abc",any()) these are still not migrated because when in Mockito only takes single argument unlike PowerMockito

[timtebeek]

Ah yes that form is not yet support; that makes this sounds more like a feature request to expand coverage of our Powermock migration recipe. Would you be willing to help out with it's implementation?

The first step would be a draft pull request that adds your case to this unit test; we can collaborate from there:

rewrite-testing-frameworks/src/test/java/org/openrewrite/java/testing/mockito/ReplacePowerMockitoIntegrationTest.java

Lines 620 to 661 in e9497f1

	void powerMockitoCallsAreReplacedByMockitoCalls() {
	//language=java
	rewriteRun(
	java(
	"""
	import org.junit.jupiter.api.BeforeEach;
	import org.powermock.api.mockito.PowerMockito;
	import java.util.Calendar;
	public class MyTest {
	private Calendar calendarMock;
	@BeforeEach
	void setUp() {
	calendarMock = PowerMockito.mock(Calendar.class);
	PowerMockito.doCallRealMethod().when(calendarMock).getTime();
	PowerMockito.doNothing().when(calendarMock).clear();
	PowerMockito.doThrow(new NullPointerException()).when(calendarMock.getCalendarType());
	}
	}
	""",
	"""
	import org.junit.jupiter.api.BeforeEach;
	import org.mockito.Mockito;
	import java.util.Calendar;
	public class MyTest {
	private Calendar calendarMock;
	@BeforeEach
	void setUp() {
	calendarMock = Mockito.mock(Calendar.class);
	Mockito.doCallRealMethod().when(calendarMock).getTime();
	Mockito.doNothing().when(calendarMock).clear();
	Mockito.doThrow(new NullPointerException()).when(calendarMock.getCalendarType());
	}
	}
	"""
	)
	);

[anand188]

@timtebeek thanks let me see if its possible for me to learn and update this