feature: supported to measure the distribution of the VFS read/write … #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agentzh
requested changes
Feb 26, 2018
samples/disk-io-blocking-vfs.sxx
Outdated
|
|
||
| probe vfs.read*.return, vfs.write*.return | ||
| { | ||
| if (sprintf("%d", pid()) =~ "^($^target)$" && begin[pid()] > 0) { |
There was a problem hiding this comment.
This is slow: see how we do this in the ngx-req-distr tool.
stap++
Outdated
| @@ -183,7 +183,7 @@ if (defined $master_pid) { | |||
| } | |||
|
|
|||
| $StdVars{pid_ok} = gen_pid_test_condition(\@pids); | |||
| $StdVars{target} = "@pids"; | |||
| $StdVars{target} = join "|", @pids; | |||
|
@agentzh all fixed, please take a look when you have time ^_^ |
|
one more thing, I rewrite It supported to monitor the master process and get all the metric of worker process, and supported |
agentzh
requested changes
Mar 13, 2018
README.markdown
Outdated
| @@ -238,6 +239,60 @@ Samples | |||
|
|
|||
| [Back to TOC](#table-of-contents) | |||
|
|
|||
| disk-io-blocking-vfs | |||
There was a problem hiding this comment.
The tool name is too verbose. vfs means virtual file system, which already implies disk I/O. Also, you are actually testing file IO instead of disk IO since there is no way to know if it indeed touches the disk device on the VFS level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…latency.
todo:
samples/disk-io-blocking-vfs.sxx