Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing local messages in modules lead to InvocationTargetExceptions #894

Open
rsteph-de opened this issue Jan 19, 2024 · 0 comments
Open
Assignees
Labels
bug A product defect that needs fixing
Milestone

Comments

@rsteph-de
Copy link
Contributor

rsteph-de commented Jan 19, 2024

Running JHove in a Non-English environment I ran into lots of InvocationTargetExceptions if localized messages were missing.
Looking into the ErrorMessage_de.properties of different modules I discovered several issues with wrong / missing message properties.
This led to NULL values in the corresponding MessageConstants enum.

  1. As a quick fix you can already set a system property to force JHove to use the English messages.
System.setProperty("module.language", "en");
  1. I am going to provide some corrections to the properties as Pull Request.

  2. It would be good to have a fallback to the default message, if a message is missing for a certain language.
    This will usually happen when error messages are added or updated.

carlwilson added a commit that referenced this issue Mar 4, 2024
…es_in_modules

provide some German messages (#894)
@carlwilson carlwilson self-assigned this Aug 22, 2024
@carlwilson carlwilson added the bug A product defect that needs fixing label Aug 22, 2024
@carlwilson carlwilson added this to the JHOVE 1.34 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

No branches or pull requests

2 participants