Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuminc testing for downstream functions #363

Open
SHAESEN2 opened this issue May 2, 2022 · 4 comments
Open

cuminc testing for downstream functions #363

SHAESEN2 opened this issue May 2, 2022 · 4 comments
Assignees
@SHAESEN2 @joanacmbarros
Labels
issue Used for project filtering
Milestone
v0.3.0

Comments

@SHAESEN2
Copy link
Collaborator

SHAESEN2 commented May 2, 2022

Testing of estimate_cuminc is now complete, but the downstream functions still need UAT for the new object.
@SHAESEN2 SHAESEN2 added the issue Used for project filtering label May 2, 2022
@SHAESEN2 SHAESEN2 added this to the v0.3.0 milestone May 2, 2022
@joanacmbarros joanacmbarros mentioned this issue May 3, 2022
Merged
11 tasks
@ddsjoberg
Copy link
Collaborator

which functions still need testing? I can work on adding them too
@SHAESEN2 @joanacmbarros

@SHAESEN2
Copy link
Collaborator Author

which functions still need testing? I can work on adding them too @SHAESEN2 @joanacmbarros

Best to check the covr report.

@ddsjoberg ddsjoberg mentioned this issue May 28, 2022
Merged
11 tasks
@ddsjoberg
Copy link
Collaborator

ddsjoberg commented May 28, 2022 •
edited
Loading

@SHAESEN2 i added a few unit tests in #387 and code coverage is up to 100% now FYI. it's not as full coverage as the tests for estimate_KM(), but it's pretty good!

Not sure if you want to keep this issue open?

@bailliem
Copy link
Collaborator

@timtreis #374 to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SHAESEN2 SHAESEN2

@joanacmbarros joanacmbarros

Labels
issue Used for project filtering
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
4 participants
@bailliem @ddsjoberg @SHAESEN2 @joanacmbarros