Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we expand the cicd testing via rhub (and re-render readme)? #202

Open
epijim opened this issue May 31, 2021 · 8 comments
Open

Should we expand the cicd testing via rhub (and re-render readme)? #202

epijim opened this issue May 31, 2021 · 8 comments
Labels
issue Used for project filtering

Comments

@epijim
Copy link
Collaborator

epijim commented May 31, 2021

https://r-hub.github.io/rhub/articles/rhub.html

above lets you test across many more platforms- should we look to more than the current few platforms?

@epijim epijim added the issue Used for project filtering label May 31, 2021
@bailliem
Copy link
Collaborator

bailliem commented May 31, 2021 via email

@epijim
Copy link
Collaborator Author

epijim commented Jul 13, 2021

Is there anyway we could set up something to push to develop to automatically build documents including manual?

Just completing the Slack message - the CICD process only writes to the deployed documentation on the pages side, it doesn't write to the base branch. Master is locked, e.g. only way in is via a PR, so we could potentially do it - but then it's more a philosophical issue of saving built artefacts to the main branch.

@epijim
Copy link
Collaborator Author

epijim commented Jul 13, 2021

We test across

- {os: windows-latest, r: 'release'}
- {os: macOS-latest, r: 'release'}
- {os: ubuntu-20.04, r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest"}
- {os: ubuntu-20.04, r: 'devel', rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest"}

I guess redhat and cent0S are used (RHEL in particular) but missing.

@epijim
Copy link
Collaborator Author

epijim commented Jul 13, 2021

will try adding this: https://github.com/r-lib/actions/tree/master/examples#render-rmarkdown

for

Is there anyway we could set up something to push to develop to automatically build documents including manual?

epijim added a commit that referenced this issue Jul 13, 2021
@epijim epijim changed the title Should we expand the cicd testing via rhub? Should we expand the cicd testing via rhub (and re-render readme)? Jul 13, 2021
@epijim
Copy link
Collaborator Author

epijim commented Jul 13, 2021

ok - so now if the readme is edited, it will auto rebuild (on any branch) @bailliem. Is this what you meant? So the 'plots' won't update on the README if nothing has changed in the readme, but they will update on the docs site. But if someone makes any changes to README.rmd, then it will make sure the version on github has the rebuilt readme.md.

https://github.com/openpharma/visR/actions/runs/1025717250

@epijim
Copy link
Collaborator Author

epijim commented Jul 13, 2021

@epijim
Copy link
Collaborator Author

epijim commented Jul 13, 2021

ok - I'll just share the index of all rebuild-readme.yaml jobs... https://github.com/openpharma/visR/actions/workflows/rebuild-readme.yaml

(forgot to add a package to the gh-action so 2nd one also failed)

@epijim
Copy link
Collaborator Author

epijim commented Jul 13, 2021

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue Used for project filtering
Projects
None yet
Development

No branches or pull requests

2 participants