Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: everything that's needed should be in the output directory #14

Open
dario-piotrowicz opened this issue Sep 20, 2024 · 0 comments

Comments

@dario-piotrowicz
Copy link
Contributor

dario-piotrowicz commented Sep 20, 2024

The build does output a worker in the specified output directory (defaulting to .next-worker).

This directory should contain everything that's required to run the worker (assets included).

But this is not so, as there are clear signs that files within .next-worker make use of files outside of the directory (making the dev/deployment of unbundled workers (--no-bundle) impossible).

For example:

I'm not sure how those files are not getting bundled by the esbuild build step 😕

We should make sure that they are actually bundled in, or if that's not possible, everything that the worker requires should just need to live in the output directory and no external file/dependency should be needed (in other words, I think that we need to make sure that wrangler dev --no-bundle works).

@dario-piotrowicz dario-piotrowicz changed the title Bug 🐛 : everything that's needed should be in the output directory 🐛 Bug: everything that's needed should be in the output directory Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant