Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConicalFrustum composite surface #3151

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

paulromano
Copy link
Contributor

Description

This PR implements a new ConicalFrustum surface that allows a user to define a conical frustum, otherwise known as a truncated cone (equivalent to the TRC macrobody in MCNP).

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@eepeterson eepeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice feature and clean implementation - just a couple small edits.

openmc/model/surface_composite.py Outdated Show resolved Hide resolved
openmc/model/surface_composite.py Outdated Show resolved Hide resolved
@eepeterson eepeterson merged commit fc3de1c into openmc-dev:develop Oct 11, 2024
16 checks passed
@paulromano paulromano deleted the conical-frustum branch October 11, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants