-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dose coefficients from ICRP 74 #3020
Add dose coefficients from ICRP 74 #3020
Conversation
Looks good to me, I wasn't sure if PR #2749 was useful to anyone. Happy to see it might be useful. |
@paulromano If you are not available, could you please suggest another independent reviewer? |
@MatteoZammataro sorry I haven't had a chance to look at this yet. As you've probably figured, I'm working to get through the backlog of PRs and will take a look at this shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatteoZammataro thanks for this PR! I made some updates on your branch and, notably, removed the ICRP 119 data for now (see my comments on #2749).
One change that's needed is that the ICRP 74 neutron data should be from Table A.41 rather than A.42. Can you make that update?
cfb835d
to
1f6460f
Compare
@paulromano Thanks for your review! I've changed the neutron data, they now come from table A.41. To be consistent, I also changed the photon data by multiplying the coefficients from Table A.1 (photon fluence to kerma) by the coefficients from A.17 (photon kerma to effective dose). I understand that this was not requested, so I'll remove it if you don't think it's necessary. I would also like to point out that using the data from A.41 and A.17, we again provide fluence to effective dose coefficients. It would be useful to also implement the ambient dose coefficients (from Table A.42 for neutrons and A.21 for photons). Ambient dose coefficients can be useful for many radiation protection studies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatteoZammataro Thanks for the updates! I made a few more changes here, including adding a script that will generate the photon effective dose per fluence values so that the origin of the data is a little more traceable. I agree with your approach of multiply the Table A.1 and A.17 values. Interestingly, looking through the literature, when people say "we used ICRP74 to compute photon dose", it gets interpreted in many different ways (some use air kerma from table A.1, some use Table A.21 ambient dose equivalent, and some use A.1×A.17).
This PR is related to issue #2516, and it's an extension of PR #2749. It adds H*(10) dose coefficients from ICRP 74.
We're introducing a new function, "dose_coefficients()."
This function has a "data_source" argument, which you can set to icrp74, icrp116, or icrp119 (the default is icrp116).
This allows for using both effective and ambient dose coefficients. When you use the effective dose ones, the syntax is basically the same as before.
Any suggestions for improvement are welcome.
I would like to extend my gratitude to @shimwell for his contributions to this topic thus far.