Releasing ID after creating dummy universe for cell plotting #2663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This might be overkill, but while reviewing @shimwell's PR providing the
Geometry.plot
option I realized that creating aUniverse
object in theCell.plot
method might reserve a bunch of IDs under the hood and potentially confuse users later on during model generation.Here I've added a function to the mixin module that allows us to release IDs for a given type. This way the next
Universe
object created after aCell.plot
call will have the same ID as it would have in the absence of the plot call.Checklist