Cylindrical bb #2621
Merged
Cylindrical bb #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimwell
reviewed
Jul 23, 2023
|
@shimwell yes I did notice the misspelling. I shouldn't have any problems running the unit tests locally in the future |
shimwell
reviewed
Jul 25, 2023
shimwell
reviewed
Jul 25, 2023
shimwell
reviewed
Jul 25, 2023
shimwell
reviewed
Jul 25, 2023
paulromano
requested changes
Jul 28, 2023
|
@shimwell can you tell if this test failed due to something beyond the remit of my changes? |
You are right, this CI error is beyond the remit of this PR. It looks like the nuclear data download is failing. Nothing for you to worry about. I can rerun the CI tomorrow and see if the download is working again |
Co-authored-by: Jonathan Shimwell <[email protected]>
paulromano
approved these changes
Aug 6, 2023
|
@paulromano Cool! Thanks Dr Romano! |
4 tasks
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
Co-authored-by: Jonathan Shimwell <[email protected]> Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very similar changes to the changes in #2620. Add bounding box, upper_right, and lower_left properties to CylindricalMesh class. Added a unit test.
Checklist