Remove use of sscanf for reading surface coefficients #2574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Periodically, users have run into issues (e.g., this recent post) where OpenMC produces the following error:
even though their geometry.xml file looks perfectly fine. I believe this is happening for international users who have a locale set such that the
sscanf
function (which is currently used for this) is sensitive to it. This PR removes the use ofsscanf
in favor of C++ streams (implemented inget_node_array
).To make sure this doesn't impact read performance on large geometry.xml files, I tested it on my ITER E-lite model (~500k surfaces) and it made no difference in the initialization time.
Checklist