Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow transfer rates with nuclides. #2564

Merged
merged 11 commits into from
Jun 26, 2023

Conversation

yardasol
Copy link
Contributor

@yardasol yardasol commented Jun 14, 2023

Description

This PR adds capabilities to enable TransferRates to work with specific nuclides. While transferring specific nuclides would most likely not occur in a real fuel processing system, it is a useful feature to have for comparison with other codes (i.e. Serpent2's repr card).

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this capability @yardasol!

openmc/deplete/transfer_rates.py Outdated Show resolved Hide resolved
openmc/deplete/transfer_rates.py Outdated Show resolved Hide resolved
openmc/deplete/transfer_rates.py Outdated Show resolved Hide resolved
openmc/deplete/transfer_rates.py Outdated Show resolved Hide resolved
openmc/deplete/transfer_rates.py Outdated Show resolved Hide resolved
tests/unit_tests/test_deplete_transfer_rates.py Outdated Show resolved Hide resolved
tests/unit_tests/test_deplete_transfer_rates.py Outdated Show resolved Hide resolved
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! @church89 do you want to take a look at this before we merge?

Copy link
Contributor

@church89 church89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yardasol, looks good thanks. We discussed it in person and I have nothing to add beside this small docstring clarifications.

openmc/deplete/abc.py Outdated Show resolved Hide resolved
openmc/deplete/transfer_rates.py Outdated Show resolved Hide resolved
openmc/deplete/transfer_rates.py Outdated Show resolved Hide resolved
openmc/deplete/transfer_rates.py Outdated Show resolved Hide resolved
openmc/deplete/transfer_rates.py Outdated Show resolved Hide resolved
openmc/deplete/transfer_rates.py Outdated Show resolved Hide resolved
@yardasol yardasol requested a review from church89 June 21, 2023 13:11
@paulromano paulromano merged commit f200e44 into openmc-dev:develop Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants