Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with program with value after position 72 #335

Open
Thibaut69 opened this issue Nov 14, 2023 · 4 comments · May be fixed by #337
Open

Issue with program with value after position 72 #335

Thibaut69 opened this issue Nov 14, 2023 · 4 comments · May be fixed by #337

Comments

@Thibaut69
Copy link

Thibaut69 commented Nov 14, 2023

When in your input cobol program, you have a string from position 73 to 79 (here value "MP029C "), this string is added as a new line in the generated cobol program like you can see below :
image

It could be great to ignore this string to prevent bad generation like we have here with extra "dirty" lines.

@samdion1994
Copy link
Collaborator

Hi @Thibaut69,

Glad to have you working with CC hope you are enjoying :)!

Published a branch with a fix feel free to use it for this Issue. I will be doing a PR in the future that will implement that fix.

@samdion1994 samdion1994 linked a pull request Nov 16, 2023 that will close this issue
@Thibaut69
Copy link
Author

Thibaut69 commented Nov 17, 2023

Hi @samdion1994, thanks a lot for your quick answer.

I'm not familiar with gradle, I've download your new branch and try to build with command : gradle build (I had 8 tests not OK, see below)
image

If i try to build without the test with command : gradle build -x test, I have a jar under build/libs

But when i try to launch ".\cobol-check.cmd -p myprog", i got an issue : "no main manifest attribut in the cobol-check.jar"
I modified the manifest file like the one of the 0.2.8 distrib of CC, and then my jar seems to start

If there is a better way to do, can you provide me the piece of documentation for newbie dev on the project ? :)

Then, when i tried to generate the cobol, I still see the problem with added lines
image

@samdion1994
Copy link
Collaborator

Hi @Thibaut69,

You are right... I add a validation can you pull and rebuild the dist then try is out :)!

@Thibaut69
Copy link
Author

Hi @samdion1994, just tested and there is no more new lines between Identification division to FILE-CONTROL, but below DATA DIVISION the new lines are still there :
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants