Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up JS build sytem (details TBD) #61

Open
outkaj opened this issue May 2, 2019 · 4 comments
Open

clean up JS build sytem (details TBD) #61

outkaj opened this issue May 2, 2019 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@outkaj
Copy link
Contributor

outkaj commented May 2, 2019

As mroth mentioned, right now the JS build system is very difficult to reason about as we have a few overlapping tools with complex rulesets. We should clean this up.

For example, it's possible (and even likely) that we may not need to use both rollup and webpack, since they have overlapping functionality.

@outkaj outkaj added the help wanted Extra attention is needed label May 2, 2019
@mroth
Copy link
Contributor

mroth commented May 2, 2019

As it is, we currently have 3 different things managing transform rules in the build:

  • some manual npm "shell" scripts that have the notion of dependencies built in via recursively calling other npm scripts (see build:esm)
  • rollup
  • webpack, which appears to duplicate some of the above two, but is used when folks run in --watch mode?

Both webpack/rollup can do watch vs builds, so it would be good to consolidate this, and get the npm script rules into the same configs.

In addition, this would ideally be done with #48 in mind -- e.g. having "already up to date" file awareness for build transforms, as currently the JS section of the build can take upwards of 5-8 minutes on a slower machine, and the entire thing is redone every time.

@outkaj
Copy link
Contributor Author

outkaj commented May 2, 2019

@jtrein we'd love your help with this project whenever you're looking for a new task

@jtrein
Copy link
Member

jtrein commented May 6, 2019

Would love to. I am busy with web worker things right now, but I will definitely look into this.

Nothing's been done on this, yet, correct? There is some discussion happening in the client's Slack channel, but it is about just getting the build to be containerized and working, before we optimize what is mentioned in this issue?

@mroth
Copy link
Contributor

mroth commented May 6, 2019

Nothing's been done on this, yet, correct? There is some discussion happening in the client's Slack channel, but it is about just getting the build to be containerized and working, before we optimize what is mentioned in this issue?

Correct. There have been some minor edits made just around getting things working, but the overall build system consolidation question was punted on so we can discuss and design when convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants