Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove 2048-bit restriction for yubikey sizes #494

Merged

Conversation

ronantakizawa
Copy link
Contributor

@ronantakizawa ronantakizawa commented Aug 8, 2024

Description (e.g. "Related to ...", etc.)

Remove 2048-bit restriction for key sizes. See #446

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@ronantakizawa
Copy link
Contributor Author

ronantakizawa commented Aug 8, 2024

Users can set their own key size via CLI (taf yubikey setup-signing-key --key-size 2048), but it currently only supports 1024 and 2048-bit keys.

Based on this article:Yubico/yubico-piv-tool#58.

Repos can be signed by 4096-bit keys.

4096-bit keys are supported on OpenPGP mode but not on PIV (What we currently use).

@ronantakizawa ronantakizawa changed the title feat: remove 2048-bit restriction for key sizes feat: remove 2048-bit restriction for yubikey sizes Aug 8, 2024
@ronantakizawa ronantakizawa marked this pull request as draft August 8, 2024 20:39
@ronantakizawa ronantakizawa marked this pull request as ready for review August 8, 2024 22:04
Copy link
Collaborator

@renatav renatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this does not fully resolve the issue, change the PR description to see #issue num. We can merge this in though once it's ready. We'll see if we can replace PIV, but that does not have to be done now

taf/api/roles.py Outdated Show resolved Hide resolved
@renatav renatav merged commit cabb5c2 into openlawlibrary:master Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants