Change v1beta1 apis #183
Closed
Change v1beta1 apis #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furykerry
reviewed
Nov 6, 2023
api/v1beta1/rollout_types.go
Outdated
| // - replicas: 2 | ||
| // This means constructing end-to-end grayscale environment, | ||
| // grayscale instance 2, where the traffic policy is trafficRouting | ||
| TrafficRouting string `json:"trafficRouting,omitempty"` |
There was a problem hiding this comment.
TrafficRouting string should be a field in CanaryStrategy
api/v1beta1/rollout_types.go
Outdated
| // TrafficRoutings hosts all the supported service meshes supported to enable more fine-grained traffic routing | ||
| // and current only support one TrafficRouting | ||
| TrafficRoutings []v1alpha1.TrafficRoutingRef `json:"trafficRoutings,omitempty"` | ||
| Batches []BatchStrategy `json:"batches,omitempty"` |
There was a problem hiding this comment.
Batches should be pointer to BatchStrategy, and in BatchStrategy , one can define replicas for each batches (maybe a field called BatchStep), and other strategy configuration
veophi
reviewed
Nov 6, 2023
| @@ -39,10 +39,6 @@ const ( | |||
| // Users can use RolloutIDLabel and RolloutBatchIDLabel to select the pods that are upgraded in some certain batch and release. | |||
| RolloutBatchIDLabel = "rollouts.kruise.io/rollout-batch-id" | |||
|
|
|||
| // RollbackInBatchAnnotation is set to rollout annotations. | |||
| // RollbackInBatchAnnotation allow use disable quick rollback, and will roll back in batch style. | |||
| RollbackInBatchAnnotation = "rollouts.kruise.io/rollback-in-batch" | |||
veophi
reviewed
Nov 6, 2023
furykerry
reviewed
Nov 6, 2023
api/v1beta1/rollout_types.go
Outdated
| @@ -124,6 +105,29 @@ type CanaryStrategy struct { | |||
| PatchPodTemplateMetadata *PatchPodTemplateMetadata `json:"patchPodTemplateMetadata,omitempty"` | |||
| } | |||
|
|
|||
| type BatchStrategy struct { | |||
| BatchStep []BatchStep `json:"batchStep"` | |||
There was a problem hiding this comment.
just name it steps in the json?
| // TrafficRoutings hosts all the supported service meshes supported to enable more fine-grained traffic routing | ||
| // and current only support one TrafficRouting | ||
| TrafficRoutings []v1alpha1.TrafficRoutingRef `json:"trafficRoutings,omitempty"` | ||
| Batches *BatchStrategy `json:"batches,omitempty"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Special notes for reviews