From 174abd6a056004adfd34c2af88b7f383c752a787 Mon Sep 17 00:00:00 2001 From: Megrez Lu Date: Thu, 27 Jun 2024 12:01:44 +0800 Subject: [PATCH] use ptr instead of struct Signed-off-by: Megrez Lu --- .../customNetworkProvider/custom_network_provider.go | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/pkg/trafficrouting/network/customNetworkProvider/custom_network_provider.go b/pkg/trafficrouting/network/customNetworkProvider/custom_network_provider.go index 6690cbfe..c2828769 100644 --- a/pkg/trafficrouting/network/customNetworkProvider/custom_network_provider.go +++ b/pkg/trafficrouting/network/customNetworkProvider/custom_network_provider.go @@ -54,7 +54,7 @@ type LuaData struct { Matches []v1beta1.HttpRouteMatch CanaryService string StableService string - RequestHeaderModifier gatewayv1beta1.HTTPRequestHeaderFilter + RequestHeaderModifier *gatewayv1beta1.HTTPRequestHeaderFilter } type Data struct { Spec interface{} `json:"spec,omitempty"` @@ -270,10 +270,7 @@ func (r *customController) executeLuaForCanary(spec Data, strategy *v1beta1.Traf // so we need to pass weight=-1 to indicate the case where weight is nil. weight = utilpointer.Int32(-1) } - var reqHeaderModifier gatewayv1beta1.HTTPRequestHeaderFilter - if strategy.RequestHeaderModifier != nil { - reqHeaderModifier = *strategy.RequestHeaderModifier - } + data := &LuaData{ Data: spec, CanaryWeight: *weight, @@ -281,7 +278,7 @@ func (r *customController) executeLuaForCanary(spec Data, strategy *v1beta1.Traf Matches: matches, CanaryService: r.conf.CanaryService, StableService: r.conf.StableService, - RequestHeaderModifier: reqHeaderModifier, + RequestHeaderModifier: strategy.RequestHeaderModifier, } unObj, err := runtime.DefaultUnstructuredConverter.ToUnstructured(data)