8343250: ArrayBlockingQueue serialization not thread safe

[kabutz]

The ArrayBlockingQueue has had a readObject() method since Java 7, which checks invariants of the deserialized object. However, it does not have a writeObject() method. This means that the ArrayBlockingQueue could be modified whilst it is being written, resulting in broken invariants. The readObject() method's invariant checking is not exhaustive, which means that it is possible to end up with ArrayBlockingQueue instances that contain null values, leading to a difference between "size()" and how many objects would be returned with "poll()".

The ABQ should get a writeObject() method that is locking on the same locks as the rest of the class.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343250: ArrayBlockingQueue serialization not thread safe (Enhancement - P4)

Reviewers

• @dmlloyd (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21783/head:pull/21783
$ git checkout pull/21783

Update a local copy of the PR:
$ git checkout pull/21783
$ git pull https://git.openjdk.org/jdk.git pull/21783/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21783

View PR using the GUI difftool:
$ git pr show -t 21783

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21783.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kabutz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@kabutz The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5dc64f7e)