-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access #21780
base: master
Are you sure you want to change the base?
Conversation
….sun.javatest.regtest.agent.MainWrapper cannot access
….sun.javatest.regtest.agent.MainWrapper cannot access
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
import javax.print.attribute.HashPrintRequestAttributeSet; | ||
|
||
public class StreamPrintingOrientation implements Printable { | ||
public StreamPrintingOrientation() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove this constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
return; | ||
} | ||
arg = Integer.parseInt(args[0]); | ||
PrintDlgPageable pd = new PrintDlgPageable(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pd
unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
} | ||
|
||
//printable interface | ||
public int print(Graphics g, PageFormat pf, int pi) throws PrinterException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throws PrinterException
not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is required...See java.awt.print.Printable spec
Couple of printing tests dont have "public" modifier so CI testing fails to run this test citing IllegalAccessException.
Fix is made to made the test class public.
Additionally, modified PrintDlgPageable.java to use PFJ and made StreamPrintingOrientation.java automated.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21780/head:pull/21780
$ git checkout pull/21780
Update a local copy of the PR:
$ git checkout pull/21780
$ git pull https://git.openjdk.org/jdk.git pull/21780/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21780
View PR using the GUI difftool:
$ git pr show -t 21780
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21780.diff
Webrev
Link to Webrev Comment