8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access #21780
+188
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….sun.javatest.regtest.agent.MainWrapper cannot access
….sun.javatest.regtest.agent.MainWrapper cannot access
|
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
TejeshR13
reviewed
Oct 30, 2024
| import javax.print.attribute.HashPrintRequestAttributeSet; | ||
|
|
||
| public class StreamPrintingOrientation implements Printable { | ||
| public StreamPrintingOrientation() { |
There was a problem hiding this comment.
Can remove this constructor.
| return; | ||
| } | ||
| arg = Integer.parseInt(args[0]); | ||
| PrintDlgPageable pd = new PrintDlgPageable(); |
| } | ||
|
|
||
| //printable interface | ||
| public int print(Graphics g, PageFormat pf, int pi) throws PrinterException { |
There was a problem hiding this comment.
throws PrinterException not required.
There was a problem hiding this comment.
it is required...See java.awt.print.Printable spec
prsadhuk
changed the title
openjdk
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of printing tests dont have "public" modifier so CI testing fails to run this test citing IllegalAccessException.
Fix is made to made the test class public.
Additionally, modified PrintDlgPageable.java to use PFJ and made StreamPrintingOrientation.java automated.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21780/head:pull/21780$ git checkout pull/21780Update a local copy of the PR:
$ git checkout pull/21780$ git pull https://git.openjdk.org/jdk.git pull/21780/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21780View PR using the GUI difftool:
$ git pr show -t 21780Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21780.diff
Webrev
Link to Webrev Comment