Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343173: Remove ZGC-specific non-JVMCI test groups #21774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Oct 29, 2024

The JVMCI should be supported by all GCs and specific
hotspot_compiler_all_gcs
group is not needed anymore.

There are few failures of JVMCI tests with ZGC happened, the bug
https://bugs.openjdk.org/browse/JDK-8343233
is filed and corresponding tests are problemlisted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343173: Remove ZGC-specific non-JVMCI test groups (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21774/head:pull/21774
$ git checkout pull/21774

Update a local copy of the PR:
$ git checkout pull/21774
$ git pull https://git.openjdk.org/jdk.git pull/21774/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21774

View PR using the GUI difftool:
$ git pr show -t 21774

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21774.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2024

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2024
@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@lmesnik The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Oct 29, 2024

Webrevs

@lmesnik
Copy link
Member Author

lmesnik commented Oct 29, 2024

/cc hotspot-compiler
/cc hotspot-gc

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@lmesnik
The hotspot-compiler label was successfully added.

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@lmesnik
The hotspot-gc label was successfully added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant