Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gen patt fix sta name writing, fixes #161 #163

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Gen patt fix sta name writing, fixes #161 #163

merged 2 commits into from
Apr 30, 2023

Conversation

MarkusMultrus
Copy link

@MarkusMultrus MarkusMultrus commented Apr 15, 2023 •
edited
Loading

Fix for Issue #161
Include terminating \0 in FIND_PAR_S() string-copy operation using strlen() and memmove(). See discussion in #161

@MarkusMultrus MarkusMultrus mentioned this pull request Apr 15, 2023
Closed
@ludomal ludomal mentioned this pull request Apr 30, 2023
Open
ludomal
ludomal approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@ludomal ludomal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This quick fix resolves the issue encountered with string memory issue.
This macro should be reworked to improve maintainability.
See #168 for future work.

@ludomal ludomal merged commit 139db49 into openitu:dev Apr 30, 2023
@MarkusMultrus
Copy link
Author

Thanks, @ludomal !

@MarkusMultrus MarkusMultrus deleted the gen-patt-fix-sta-name-writing branch May 1, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludomal ludomal ludomal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkusMultrus @ludomal @FhGSpCo