Update OIDRedirectHTTPHandler.h #820
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix macOS startHTTPListener memory crash if there is an error and return nil URL.
fix startHTTPListener with port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix macOS startHTTPListener memory crash if there is an error and return nil URL
related issue: #107
When there is a starting error happened, the Swift call to startHTTPListener will crash, because of the return URL is nullable but the interface announce it nonnull.
The right behavior should throw an SwiftError.
after this fix, the Swift call to startHTTPListener will be right to handle the error.