Fix VCD generation from Verilator model #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ failed run, report available here. |
|
Hello @pcotret |
|
I'll try it! |
|
❌ failed run, report available here. |
|
CI goes red again, only for the "Environment check" step. |
|
❌ failed run, report available here. |
1 similar comment
|
❌ failed run, report available here. |
|
I suspect a misfunctionality of the CI. I relaunched. |
|
✔️ successful run, report available here. |
|
Now it is GREEEEN. Thanks for the contribution. I merge. |
1 task
Abdulwadoodd
pushed a commit
to 10x-Engineers/cva6
that referenced
this pull request
Sep 15, 2023
* tools/vptool/vptool/vp.py (OrderedDict): Import from 'collections', not from 'typing'. Signed-off-by: Zbigniew Chamski <[email protected]>
Abdulwadoodd
pushed a commit
to 10x-Engineers/cva6
that referenced
this pull request
Sep 15, 2023
…rect-import Fix incorrect Python import (fixes issue openhwgroup#1341.)
Abdulwadoodd
pushed a commit
to 10x-Engineers/cva6
that referenced
this pull request
Sep 15, 2023
* tools/vptool/vptool/vp.py (OrderedDict): Import from 'collections', not from 'typing'. Signed-off-by: Zbigniew Chamski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an answer to my issue described at #1340
Quick comments:
-j${NUM_JOBS}in Verilator generation as it basically shut down my VM (8 cores...).