Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Integrate lint checking mechanism in GitHub actions #1394

Open
1 task done
fatimasaleem opened this issue Sep 13, 2023 · 1 comment
Open
1 task done

[TASK] Integrate lint checking mechanism in GitHub actions #1394

fatimasaleem opened this issue Sep 13, 2023 · 1 comment
Assignees
@saadwaheed-10xe
Labels
Component:Tool-and-build For issues in the tool and build flow (e.g. Makefile, FuseSoc, etc.) Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) CV32A60AX Part: Application configuration (former "step1") CV32A65X Part: Embedded configuration Status:New Newly created issue, nobody has looked at it yet. Type:Enhancement For feature requests and enhancements Type:Lint Lint error or compile warning Type:Task Project related task

Comments

@fatimasaleem
Copy link
Contributor

Is there an existing CVA6 task for this?

  • I have searched the existing task issues

Task Description

RTL Linting is used to verify adherence to specified design coding rules that prevent synthesis issues, functional bugs and enforce coding styles for readability & re-use. For that purpose, we have to enable lint warnings and remove/waive them where necessary.

While resolving the current lint warnings, we need to make sure that new design changes are not adding new lint warnings. For this purpose we need to have integrate lint checking mechanism in CI.

Required Changes

Setup CI yml for lint warnings, which should ignore the known current warnings

Current Status

No lint check available

Risks

No response

Prerequisites

No response

KPI (KEY Performance Indicators)

No response

Description of Done

Running lint CI

Associated PRs

No response
@fatimasaleem fatimasaleem added Component:Tool-and-build For issues in the tool and build flow (e.g. Makefile, FuseSoc, etc.) CV32A65X Part: Embedded configuration CV32A60AX Part: Application configuration (former "step1") Status:New Newly created issue, nobody has looked at it yet. Type:Lint Lint error or compile warning Type:Enhancement For feature requests and enhancements labels Sep 13, 2023
@JeanRochCoulon
Copy link
Contributor

Hello @saadwaheed-10xe @fatimasaleem Big #1513 PR will add a big quantity of code lines. I fear this will add new LINT warnings. I would be pleased to now your recommendation, should you check the LINT regression on this PR ? Do not hesitate to propose.

@JeanRochCoulon JeanRochCoulon added Type:Task Project related task Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saadwaheed-10xe saadwaheed-10xe

Labels
Component:Tool-and-build For issues in the tool and build flow (e.g. Makefile, FuseSoc, etc.) Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) CV32A60AX Part: Application configuration (former "step1") CV32A65X Part: Embedded configuration Status:New Newly created issue, nobody has looked at it yet. Type:Enhancement For feature requests and enhancements Type:Lint Lint error or compile warning Type:Task Project related task
Projects
CVA6 Project Task Board
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JeanRochCoulon @saadwaheed-10xe @fatimasaleem