Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPage doesn't work with fake friendly URLs #9

Open
Mark-H opened this issue Nov 18, 2011 · 4 comments
Open

getPage doesn't work with fake friendly URLs #9

Mark-H opened this issue Nov 18, 2011 · 4 comments

Comments

@Mark-H
Copy link

Mark-H commented Nov 18, 2011

When using furls through a plugin that sets a placeholder which is being used in a snippet call being paginated with getPage, there's the issue that getPage doesn't take that friendly URL into account.

While makeUrl(resource ID) is a proper way of generating that next/previous links, wouldn't it be better to look at the requested URI instead, to preserve compatibility with custom furls?

@opengeek
Copy link
Owner

getPage doesn't generate any URLs. You'll need a Snippet for generating your custom URLs that you can call in getPage's tpl properties and/or whatever Snippet you are calling with getPage.

@rtripault
Copy link

Mark you may want to look at my pull request (#7). getPage makes url via include.getpage.php, so if that could be defined with a parameter (&makeUrl='path/to/your/makeUrl.php') you could make use of your own makeUrl method :)

@opengeek
Copy link
Owner

Oh, I see the issue... I'll look at the PR, though I am more inclined to allow a callback to be defined than a path to a php file.

@Mark-H
Copy link
Author

Mark-H commented Nov 18, 2011

A callback would be super duper awesome. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants