-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨(plugin) add notifications to courses #2239
base: master
Are you sure you want to change the base?
✨(plugin) add notifications to courses #2239
Conversation
bf80c38
to
2272d34
Compare
Add a new plugin to create warning or information notifications. This plugin is only available on course detail pages.
2272d34
to
fd83742
Compare
Hey Sandro, look's interesting. I'll have few suggestion to improve your contribution. First, there is already an existing banner component and I think you could be use it here. richie/src/richie/apps/courses/templates/courses/cms/fragment_error_detail_template_banner.html Lines 1 to 14 in fcff6bc
Then, I wonder if this the right place to put the notification. |
Do you think it makes sense for us to meet in the middle? This banner is more "informative" than anything else. The one you show in the images seems to be related more to errors. When I created this, I focused on the course. The idea is to pass messages to the students inside the course page, hence why I chose to put it where it is. I can refactor with my idea in mind. What do you think? Would a mix of both make sense? |
I don't dislike the idea at all. I just want to restrict this kind of notifications to the courses and programs, for now. |
Yup sorry, I realized that the example of the footer placeholder was not a good one. |
Make sense. I'll check and work on it. I might create some additional styles to have different levels of alert states. |
Add a new plugin to create warning or information notifications.
This plugin is only available on course detail pages.
Closes #2238