Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️(backends) migrate LRSHTTPBackend to LRSDataBackend #524

Merged
merged 1 commit into from
Dec 12, 2023

Commits on Dec 12, 2023

  1. 🏗️(backends) migrate LRSHTTPBackend to LRSDataBackend

    The interface of the http backends are now very similar
    to the data backends.
    Thus, to limit redundant interfaces we opt to move the
    LRSHTTPBackend and AsyncLRSHTTPBackend to the data
    backend package.
    We also update the cli write command to align more with
    the data backend interface.
    Moreover, the LRSDataBackend no longer inherits from
    the AsyncLRSDataBackend to alow it's usage in an async
    context.
    Finally, the behavior of the sync and async versions of
    the lrs data backend are very similar.
    Thus, to keep both implementations inline, we tests both
    of them in the same file.
    SergioSim committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    6a3a517 View commit details
    Browse the repository at this point in the history