Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss the return type of query_statements_by_ids methods #456

Open
wilbrdt opened this issue Oct 11, 2023 · 0 comments
Open

Discuss the return type of query_statements_by_ids methods #456

wilbrdt opened this issue Oct 11, 2023 · 0 comments
Labels
question
Milestone
5.0

Comments

@wilbrdt
Copy link
Contributor

wilbrdt commented Oct 11, 2023 •
edited
Loading

Feature Request

We should discuss the return type of the query_statements_by_ids backend methods, if we should keep them as they will be in v4.0.0 (returning a sync/async generator) or if they should return a list instead.

query_statements_by_ids returning generators seems to induce a lot of code replications and greatly complicates the API, for a potentially (not measured) small improvement in performance.

Originally found by @SergioSim in #416 (comment)
@wilbrdt wilbrdt mentioned this issue Oct 11, 2023
Merged
13 tasks
@wilbrdt wilbrdt added this to the 5.0 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
Ralph roadmap
Status: Todo
Milestone
5.0
Development

No branches or pull requests
1 participant
@wilbrdt