Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a general xAPI validation option for the command validate #388

Open
wilbrdt opened this issue Jul 10, 2023 · 2 comments
Open

Add a general xAPI validation option for the command validate #388

wilbrdt opened this issue Jul 10, 2023 · 2 comments

Comments

@wilbrdt
Copy link
Contributor

wilbrdt commented Jul 10, 2023

Feature Request

Is your feature request related to a problem or unsupported use case? Please describe.
Right now, we are validating xAPI statements against our xAPI models implemented in Ralph.

Describe the solution you'd like
We could imagine that we would want to validate xAPI statements for profiles not defined in Ralph (we won't ever have all the profiles implemented in Ralph).
We could make a general xAPI validation, which checks that actor, id, object and verb are present.
We could use the LaxStatements pydantic model.
The command could be:
bin/ralph validate -f xapi to validate generic xAPI format, and bin/ralph validate -f xapi --full to validate against profiles?
or
bin/ralph validate -f xapi --generic and bin/ralph validate -f xapi --full

Discovery, Documentation, Adoption, Migration Strategy
Of course, documentation would need an update.

@quitterie-lcs
Copy link
Member

quitterie-lcs commented Jul 11, 2023

Why not using the BaseXapiStatement model rather than the LaxStatements ?

@wilbrdt
Copy link
Contributor Author

wilbrdt commented Jul 11, 2023

You're right, it's preferable to use BaseXapiStatement instead of LaxStatements that was created for a performance purpose

@wilbrdt wilbrdt added this to the 5.0 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants