-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix library install directories on Windows #634
base: main
Are you sure you want to change the base?
Conversation
From #633 (comment):
@dsuponitskiy Sure, let me know if I can be of any help. Right now, I don't see any downsides to the proposed change, since it essentially leaves all non-DLL systems unchanged and fixes only the install locations for DLL systems. Note that the proposed change is also the default for the currently required minimum CMake version 3.5.2, while at least since CMake version 3.14 it is possible to change the install location ad hoc during configure time using the |
@dsuponitskiy Are there any updates on this issue? |
@sloede - you may want to change your code to be conditional to WINDOWS
|
I do not think that's necessary. The proposed parameter settings should work for all Unix-like and Windows-like systems. In fact, I think it has been the default for a number of CMake releases now. |
good to know; thanks |
@yspolyakov are there any updates on this issue? I'd be happy to update the PR such that it can be merged eventually (I don't think there is much to it anyways) |
Currently, OpenFHE installs all library products in the
lib
directory. AFAIK, this is wrong (or at least bad practice) on Windows, where the.dll
files belong into thebin
directory.This PR remedies this by configuring the library installation in CMake to do The Right Thing:
lib
.dll.a
or.lib
libraries go tolib
, while the dynamic libraries go tobin