Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script without Twisted #19

Open
admwx7 opened this issue Dec 6, 2013 · 19 comments
Open

Install script without Twisted #19

admwx7 opened this issue Dec 6, 2013 · 19 comments
Labels

Comments

@admwx7
Copy link

admwx7 commented Dec 6, 2013

We need an install script that will add our code to a server that already has Twisted installed on it, depending on implementation we may be able to change this from a script to a How-To, will definitely require a document that outlines what versions of Twisted a given version of OpenFaux-Server is supported on (yay compatibility).

@alexa-infra
Copy link

Just wondering why server does not use python virtualenv, and why installation script is only for apt-based linux distribs? virtualenv should solve almost all problems with installation

@zlatanvasovic
Copy link

Aww. I'll rewrite script to be compatible with yum ones... or maybe just do a compile? :D

@Sp3ctr3
Copy link
Contributor

Sp3ctr3 commented Jan 4, 2014

@alexa-infra We just wanted a quick install script at that moment. If you can create one with virtualenv that would be great!

@zlatanvasovic
Copy link

No! Don't touch script. I'm rewriting it. :P

2014/1/4 Yashin Mehaboobe [email protected]

@alexa-infra https://github.com/alexa-infra We just wanted a quick
install script at that moment. If you can create one with virtualenv that
would be great!


Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-31579729
.

Zlatan Vasović - ZDroid

@alexa-infra
Copy link

@zdroid yum? :D what is about gentoo? or even worst - ms windows? IMO simple requirements.txt for pip is the best solution. And after that you could add scripts for platforms to install python/pip/whatever. Moreover an user could decide - use or not virtualenv, installation scripts etc..

@zlatanvasovic
Copy link

Aw, one system per one.

2014/1/4 Alexey Vasilyev [email protected]

@zdroid https://github.com/ZDroid yum? :D what is about gentoo? or even
worst - ms windows? IMO simple requirements.txt for pip is the best
solution. And after that you could add scripts for platforms to install
python/pip/whatever. Moreover an user could decide - use or not virtualenv,
installation scripts etc..


Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-31580071
.

Zlatan Vasović - ZDroid

@zlatanvasovic
Copy link

3a38314

Now you can touch script. :)

@alexa-infra
Copy link

why not just run the following?..

pip install -q -r requirements.txt

and requirements.txt

python-twisted>=13.2.0
webapp2>=2.5.1
Paste>=1.7.5
WebOb>=1.2.3

@zlatanvasovic
Copy link

Do it.

2014/1/4 Alexey Vasilyev [email protected]

why not just run the following?..

pip install -q -r requirements.txt

and requirements.txt

python-twisted>=13.2.0
webapp2>=2.5.1
Paste>=1.7.5
WebOb>=1.2.3


Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-31580644
.

Zlatan Vasović - ZDroid

@Sp3ctr3
Copy link
Contributor

Sp3ctr3 commented Jan 4, 2014

BTW only twisted is the requirement here. The rest are not needed.

@zlatanvasovic
Copy link

Ok. Let's nuke them.

2014/1/4 Yashin Mehaboobe [email protected]

BTW only twisted is the requirement here. The rest are not needed.


Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-31580931
.

Zlatan Vasović - ZDroid

@Sp3ctr3
Copy link
Contributor

Sp3ctr3 commented Jan 5, 2014

I already did it.

@zlatanvasovic
Copy link

I saw.

2014/1/5 Yashin Mehaboobe [email protected]

I already did it.


Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-31600788
.

Zlatan Vasović - ZDroid

@indradhanush
Copy link

Why isn't there any requirements.txt file? That way we can keep track of the dependencies. Easier to set up the dev environment.

@zlatanvasovic
Copy link

It'll be here.

2014/1/5 Indradhanush Gupta [email protected]

Why isn't there any requirements.txt file? That way we can keep track of
the dependencies. Easier to set up the dev environment.


Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-31605721
.

Zlatan Vasović - ZDroid

@indradhanush
Copy link

So the change has been made and it's yet to merge?

@zlatanvasovic
Copy link

Not, it isn't done. :D

@indradhanush
Copy link

Okay. I'll open a new issue and do it then. And we can call "pip install -r requirements.txt" from the install script here so it runs on the server too. Although virtualenv is better on the server too. By the way. Which would be a better way to contribute? Push changes to the my forked repository and then create a pull request or just push here directly in a new branch?

@zlatanvasovic
Copy link

Make new branch here, no need to fork if you are team member. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants