chore: remove bok-choy usage #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salman2013
force-pushed
the
salman/remove-bok-choy
branch
from
cd2cb1c
to
8150ab2
Compare
farhan
suggested changes
Nov 3, 2023
setup.py
Outdated
| @@ -23,11 +23,11 @@ def package_data(pkg, root_list): | |||
|
|
|||
| setup( | |||
| name='xblock-image-explorer', | |||
| version='2.0', | |||
| version='2.1', | |||
There was a problem hiding this comment.
I think it good time to add path version as well
2.1.0
setup.py
Outdated
| description='XBlock - Image Explorer', | ||
| packages=['image_explorer'], | ||
| install_requires=[ | ||
| 'XBlock>=1.2', | ||
| 'XBlock>=1.8.1', |
There was a problem hiding this comment.
Its not required as we have provided backward compatibility
farhan
approved these changes
Nov 3, 2023
feanil
approved these changes
Nov 6, 2023
This was referenced Nov 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the bok-choy has been deprecated openedx/public-engineering#13, we are removing its usage from the code in this PR.
Ticket : https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=40721593
In this PR i also updated xblockutils' new hierarchy for classes but with support for backward compatibility for Quince earlier releases.
Ticket: https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=41364624