Django 4.2 support #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awais786
force-pushed
the
salman/django-4.2.upgrade
branch
2 times, most recently
from
a67c3fc
to
226ad23
Compare
awais786
force-pushed
the
salman/django-4.2.upgrade
branch
from
4d84980
to
0bb3ba6
Compare
tox.ini
Outdated
| @@ -21,17 +21,17 @@ whitelist_externals = | |||
| deps = | |||
| django31: Django>=3.1,<3.2 | |||
There was a problem hiding this comment.
I guess, this line should be removed as well.
salman2013
commented
Aug 2, 2023
mumarkhan999
reviewed
Aug 2, 2023
| @@ -19,19 +19,17 @@ whitelist_externals = | |||
| mkdir | |||
| rm | |||
| deps = | |||
| django31: Django>=3.1,<3.2 | |||
| django32: Django>=3.2,<4.0 | |||
There was a problem hiding this comment.
We only need to remove django31: Django>=3.1,<3.2.
django32 shouldn't be removed.
Am I right?
mumarkhan999
reviewed
Aug 2, 2023
| mkdir -p {toxinidir}/var/logs | ||
| rm -rf {toxinidir}/var/logs/* | ||
| pytest {posargs} |
There was a problem hiding this comment.
@awais786 make this change when fixing test cases.
added 2 commits
August 2, 2023 15:36
mumarkhan999
previously requested changes
Aug 2, 2023
requirements/travis.txt
Outdated
| # via edx-i18n-tools | ||
| platformdirs==2.5.2 | ||
| <<<<<<< HEAD |
awais786
approved these changes
Aug 4, 2023
mumarkhan999
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 Update package version to '0.4.0'