Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test failure] TC_LEARNER_44: Can't change site to some languages #347

Closed
Colin-Fredericks opened this issue May 17, 2024 · 7 comments
Closed
Labels
redwood release testing Affects the upcoming release (attention needed)
Milestone

Comments

@Colin-Fredericks
Copy link

Release

Redwood

Expected behavior

Changing the language for the site should make text appear in other languages.

Actual behavior

For some languages it works; for others it doesn't.

Steps to reproduce

  1. Open up account settings, like https://apps.redwood.demo.edly.io/account/#site-preferences
  2. Click or scroll to "Site Preferences".
  3. Click "Edit" next to "Site language".
  4. Pick a language. I chose French.
  5. Click "Save".
  6. Reload the page.
  7. Notice that the page is still in English and the setting has swapped back to English. (Not sure what happens if your site-wide default is set to something else.)

In a really weird twist, some languages work and some do not!

  • Arabic (العربية) - Works! Including right-to-left. Getting it back out of Arabic was a slight challenge, on account of I do not read Arabic.
  • Bahasa Indonesia - No luck. The preference sticks, but the site does not change.
  • 中文 (简体) (Simplified Chinese) - Works!
  • dansk - Works!
  • Espaõl (Latinoamérica) - Works!
  • Français - No luck.
  • German - Works!
  • עברית (Hebrew) - Works!
  • साइट प्राथमिकताएँ (Hindi) - Works!
  • Italian - Molto bene!
  • Kiswahili - Poa kichizi kama ndizi. (That means it works.) (Technically it means "Crazy cool like a banana", and it's basically the only Kiswahili I know.)
  • 한국어 (대한민국) (Korean, RoK) - No luck. Site does not change, preference does not stick.
  • Português - Works!
  • Türkçe - Works!
  • Українська (Ukranian) - Works!

So a lot of them work, but not all of them. It seems my initial choice of French was sort of lucky here - I might not have realized this was broken otherwise.

Additional information

Fun fact: Pasting Hebrew or Arabic into the editor in GitHub gives you some really weird behavior, which I suppose I should have expected.

@mariajgrimaldi mariajgrimaldi added the release testing Affects the upcoming release (attention needed) label May 17, 2024
@mariajgrimaldi mariajgrimaldi added this to the Redwood.1 milestone May 17, 2024
@felipemontoya
Copy link
Member

I just tested this with "Español (Latinoamerica) and it failed likely due to a CORS issue.

image

@GlugovGrGlib
Copy link
Member

@mariajgrimaldi @cmltaWt0 I'm facing exactly the same issue with CORS as @felipemontoya posted above.

I believe the issue is that endpoint /i18n/setlang/ returns Redirect to / instead of JSON response, and when Learner-dashboard MFE is enabled it's being blocked by CORS policy.

Please see screenshots:

Chromium:
image
Firefox:
Screenshot 2024-05-29 at 14 12 03

Did this case pass for Quince, since learner-dashboard MFE was included in the community release?

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented May 30, 2024

@GlugovGrGlib: we don't have a failing report for quince, so I'll be testing in a quince installation to be sure.

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented May 30, 2024

@GlugovGrGlib: I tested here https://apps.sandbox.openedx.edly.io/account/, and I can confirm it is also happening in quince. I can change the language, but the changes are reflected after reloading. Also, I get the CORS error as well. I haven't tested all the languages yet.

image

@mariajgrimaldi
Copy link
Member

I'll be opening an issue in the tutor-mfe repo so we can address it there. Thank you all!

@mariajgrimaldi mariajgrimaldi modified the milestones: Redwood.1, Redwood.3 Sep 14, 2024
@mariajgrimaldi
Copy link
Member

In the last BTR meeting, Adolfo assigned himself to address this issue here: openedx/frontend-app-account#1052

@mariajgrimaldi
Copy link
Member

Fixed by openedx/frontend-app-account#1139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redwood release testing Affects the upcoming release (attention needed)
Projects
Development

No branches or pull requests

5 participants