[TC_LEARNER_39] Notes tab linking not working

[jfavellar90]

Links in the notes tab are not redirecting to the right units containing student notes.

Steps:

Enable Notes in a Course Advanced settings
Open Course as a Student
Check Notes tab
Open any Unit in a subsection
Select text to note
Save the note
Advance to the next unit in the sequential
Check the Notes tab
Follow the note link in the Notes tab
Check you're in the last visited unit, not the one containing the note

Status: FAILED

I think this is due to the fact that the notes tab page is outside the MFE (is served by LMS directly) so it is using legacy links that are being translated properly to MFE links

[jfavellar90]

label: olive testing

[jalondonot]

Hi @jfavellar90, are you planning to work on fixing this issue or should we tag it as "help wanted" to move it forward?

[jalondonot]

Hi @jfavellar90, any news on this? @DeanJayMathew is this issue still happening?

[jfavellar90]

@jalondonot sorry for the late answer. I can take over this one to check if this is still happening, and if that's the case, try to propose a solution, otherwise, I'd tag this issue as "help wanted"

[jfavellar90]

@jalondonot last 2 weeks I haven't had the time to push this task. I'll be putting aside some time this week and I'll post an update on this task.

[jalondonot]

@jfavellar90, do hoy have any updates on this?

[jfavellar90]

@jalondonot this is still WIP. It is still happening in Olive and I think the best approach is to move the notes page to a micro-frontend (it is still served via LMS directly). This bug should not be considered a blocker at all for palm cutoff. @arbrandes is it OK if I move forward and work on this one? I need assistance finding the best place to put this page in the micro-frontends.

[arbrandes]

@jfavellar90, any work on moving pages to MFEs is most welcome, indeed. :)

To avoid coordination issues, I suggest you make this a stand-alone MFE. Like with the Discussions MFE, if enabled, clicking on the Notes tab would redirect to the (theoretical) Notes MFE.

[mariajgrimaldi]

@jfavellar90: are these two (#233 and #227) issues related? If they are, can we close one? So it's easier to maintain the status up to date

[arbrandes]

@jfavellar90, for the record, there's no need to wait on the Modular Domains work if you want to get started on this. However, I would strongly suggest mocking up the feature (figma, maybe?) and getting some product feedback (is it going to have 1-to-1 feature parity with the current notes frontend?) before actually diving into the code.

[jfavellar90]

@jfavellar90: are these two (#233 and #227) issues related? If they are, can we close one? So it's easier to maintain the status up to date

@mariajgrimaldi These issues are unrelated so for me, it makes sense to manage them separately.

[santiagosuarezedunext]

With a designer from my company we will make a prototype for the new mfe of notifications, we will be commenting when we make progress and we will ask for comments

[jfavellar90]

Just to complement the comment from @santiagosuarezedunext , we met internally to explain the technical problem to my teammates and the next step for us will be the creation of a prototype for the stand-alone notes MFE and socialize it to get feedback. I'm not sure if this issue "[TC_LEARNER_39] Notes tab linking not working" maps properly the work we are going to do. @arbrandes should we create a new issue related to this New MFE creation? Not sure if it should land here in the BTR WG or better to move it to the Frontend WG

[santiagosuarezedunext]

Hello, together with our designer @maguilarUXUI we created the following prototype that updates the notes module based on Paragon to do it in an MFE.
The only extra thing we added from the current version is that we include a full breadcrumb of where the note is in the course: Section > Subsection > Unit
I am attentive to your comments.

https://www.figma.com/proto/szKm2n7qi6sI3BAirYLavL/Notas-MFE?scaling=scale-down&page-id=0%3A1&node-id=9-787&starting-point-node-id=5%3A21

[maguilarUXUI]

As @santiagosuarezedunext mentions, this proposal is based on the current functionality of notes, and the variations are minimal. We rely on the Paragon Design System for the UI.

[arbrandes]

This is great! I think this is a good time to bring product into it. Can you folks make it into one of the upcoming Product WG meetings to present this?

This would also be a good conversation for one of the upcoming frontend WG ones, too.

[santiagosuarezedunext]

@arbrandes A little update
We discussed another prototype similar to this yesterday (April 4) at the ui ux working group meeting, they'll give us feedback and then we'll pass it on to the product working group for approval. We can do the same with this prototype at the next uiuxwg meeting.

[mariajgrimaldi]

Hello @santiagosuarezedunext! Would you happen to know the status of this issue? We'd appreciate any update. Thanks!

[mariajgrimaldi]

I'm not sure what the state of this is since Santiago is no longer working on this project, but I think this should be a product proposal instead. So this issue addresses the current issues with notes, maybe linking to the product proposal as a long-term proposal.