Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staff Permission vanishes #241

Closed
ichintanjoshi opened this issue Mar 6, 2024 · 6 comments
Closed

Staff Permission vanishes #241

ichintanjoshi opened this issue Mar 6, 2024 · 6 comments
Labels
bug Report of or fix for something that isn't working as intended

Comments

@ichintanjoshi
Copy link

ichintanjoshi commented Mar 6, 2024

Description

If a user has staff permission in django admin (different compared to studio staff or course staff permission). And they visit the studio and go to any course that is not created by them, after that if they go to Content dropdown -> Pages & Resources they'll get an error and their staff permission in django admin vanishes.

Step To Reproduce

  1. Go to Studio as Admin

  2. Create a course

  3. Sign up as new user in incognito tab

  4. Back to admin user, activate the user and give staff permission
    image

  5. Go back to incognito tab with new user signed in and go to studio
    image

  6. Select the course created by studio

  7. Click on "Content" Dropdown
    image

  8. Click on "Pages & Resources"

  9. It'll show an error
    image

  10. Back to admin user and check the user in admin panel, we see that staff permission is gone.
    image

(NOTE:- This issue will not occur if the user is present in the system and has staff permission already, it only occurs for users who are not present at the time of course creation or do not have staff permission at the time of creation)

Expected Result

Newly created users with staff permission should be able to see the page like following

image

Workaround

  • If this newly created user is given "Course Team" access from the studio, the same behaviour works.

Specs

  • Tutor: 16.x.x and 17.0.0 and 17.0.1
  • Open edX: palm and quince.1

This issue is raised after enquiring in slack about where to raise the issue. This issue is raised as a result of discussion on
this thread. Please let me know if this is not the correct place for creating the issue.

@arbrandes arbrandes added the bug Report of or fix for something that isn't working as intended label Mar 6, 2024
@arbrandes
Copy link

@ichintanjoshi, has this been reproduced on master? If not, which released version?

@ichintanjoshi
Copy link
Author

ichintanjoshi commented Mar 6, 2024

@arbrandes sorry I forgot to add those details, No I haven't tested it on master. Will take a look if tutor works with master

This was done on
Tutor: 16.x.x and 17.0.0 and 17.0.1
Open edX: palm and quince.1

@arbrandes
Copy link

Tutor certainly does work with master, but you have to install its nightly branches manually. See https://docs.tutor.edly.io/tutorials/nightly.html.

@ichintanjoshi
Copy link
Author

Hi @arbrandes yes this also gets reproduced in master

@manja-o
Copy link

manja-o commented Apr 8, 2024

Hi, @arbrandes
Could you please provide me with an update on the progress for that issue if any?

@ormsbee
Copy link

ormsbee commented May 17, 2024

This was fixed as part of a security fix. Please see https://discuss.openedx.org/t/upcoming-security-fix-for-edx-platform-on-2024-05-17/13004/2 for the post and details linked off of it.

@ormsbee ormsbee closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

4 participants