Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added expanded tokens #3222

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Sep 8, 2024

Description

  • added expanded tokens
  • fixed some bugs
  • created an abstracted CSS variables

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Sep 8, 2024
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 8, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 8, 2024

Thanks for the pull request, @PKulkoRaccoonGang!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/paragon-working-group. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft September 8, 2024 15:39
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title feat: added expanded tokens DRAFT: added expanded tokens Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (a0baaa6) to head (5b0e94f).
Report is 1 commits behind head on Peter_Kulko/style-dictionary-v4.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           Peter_Kulko/style-dictionary-v4    #3222   +/-   ##
================================================================
  Coverage                            93.76%   93.76%           
================================================================
  Files                                  229      229           
  Lines                                 3784     3784           
  Branches                               902      906    +4     
================================================================
  Hits                                  3548     3548           
- Misses                                 229      232    +3     
+ Partials                                 7        4    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Annotation/index.scss Outdated Show resolved Hide resolved
src/Carousel/index.scss Outdated Show resolved Hide resolved
src/Card/index.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming together beautifully! Left a couple comments where the diff doesn't match up with what was being discussed in prior comment threads, but overall it's looking great!

styles/css/core/abstract-variables.css Outdated Show resolved Hide resolved
styles/css/themes/light/index.css Outdated Show resolved Hide resolved
styles/scss/core/core.scss Outdated Show resolved Hide resolved
www/src/scss/openedx-theme.scss Show resolved Hide resolved
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all of the places mentioned in #3222 (comment) and added checkmarks. Most of them look perfect! I left comments on the ones that I noticed issues with:

Find where we're using the consolidated token

Make composite token

Make composite token

  • Done?
    "$value": "-apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, 'Noto Sans', sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji'",

tokens/src/core/components/Dropdown.json Outdated Show resolved Hide resolved
tokens/src/core/global/transition.json Outdated Show resolved Hide resolved
tokens/src/core/global/typography.json Outdated Show resolved Hide resolved
@PKulkoRaccoonGang
Copy link
Contributor Author

@brian-smith-tcril @adamstankiewicz there seems to be a small issue with the fonts after the latest changes to the documentation site. It may have happened after this da00992 (#3186) commit.
Is this the expected font size?

Master
image

Current
image

image

@adamstankiewicz
Copy link
Member

@brian-smith-tcril @adamstankiewicz there seems to be a small issue with the fonts after the latest changes to the documentation site. It may have happened after this da00992 (#3186) commit. Is this the expected font size?

@PKulkoRaccoonGang I believe this style discrepancy might be resolved by addressing this comment. By ensuring the token value is an array of multiple elements (one per font) vs. a single array element containing all fonts, it seems like the font size and typography style will be fixed, as seen below:

image

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking through the wild ride of a PR review this was! Let's land this!

@adamstankiewicz
Copy link
Member

Great job, @PKulkoRaccoonGang! Excited to see this land. Thanks for working through the iterations.

refactor: corrected expanded tokens

refactor: code refactoring

refactor: created an abstracted CSS variables

refactor: added missing expanded tokens

refactor: added missing expanded tokens

refactor: small refactoring after review

refactor: corrected imports for CSS files

feat: expanded --pgn-transition-carousel-base token, some refactoring

fix: corrected --pgn-transition-base-timing-function value

refactor: some refactoring and updates

refactor: corrected progress-bar and typography tokens
@PKulkoRaccoonGang PKulkoRaccoonGang merged commit 70673e4 into Peter_Kulko/style-dictionary-v4 Oct 27, 2024
6 checks passed
@PKulkoRaccoonGang PKulkoRaccoonGang deleted the Peter_Kulko/expanded-tokens-value branch October 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants