-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add defaults to theme-urls.json output on build #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
🎉 This PR is included in version 21.0.0-alpha.40 🎉 The release is available on: Your semantic-release bot 📦🚀 |
monteri
pushed a commit
to raccoongang/paragon
that referenced
this pull request
Aug 17, 2023
PKulkoRaccoonGang
pushed a commit
to raccoongang/paragon
that referenced
this pull request
Aug 18, 2023
🎉 This PR is included in version 22.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 1, 2024
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 4, 2024
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 4, 2024
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends
build-scss.js
Node.js script to include optional--defaultThemeVariants
option to customize the default theme variants to include in thetheme-urls.json
output.Ensures the
theme-urls.json
output looks like the following, with the additional of thedefaults
object property in favor of the previousdefault
anddark
properties:Deploy Preview
N/A
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist