-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed gh-pages-deploy-action from release.yml #2467
Conversation
Thanks for the pull request, @ThaungThanHan! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2467 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 234 234
Lines 4161 4161
Branches 1001 1001
=======================================
Hits 3803 3803
Misses 351 351
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Hi @ThaungThanHan , we need to have a valid Contributor License Agreement (CLA) in place for all contributions. See the welcome message above for the details about how to enroll. The process is different depending upon whether you are making this contribution as an individual or on behalf of your employer. Also I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard? |
Hi @ThaungThanHan! Just checking to see if you were able to submit your CLA form? Please let me know if you have any questions. Thanks! |
Hi @ThaungThanHan! Just checking in to see if you plan to pursue this pull request? |
Hi @ThaungThanHan! I'm going to close this for now. If you would like to pursue in the future, we can reopen. Thanks! |
@ThaungThanHan Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@ThaungThanHan Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
I have removed github-pages-deploy-action from release.yml. Fixes: #2465
Deploy Preview
(https://github.com/ThaungThanHan/paragon/blob/9ffc37a18fc183a9b882a2cdc7a4a07661d35c43/.github/workflows/release.yml#L39)
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist