Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: initial autoResize functionality #2453

Conversation

monteri
Copy link
Contributor

@monteri monteri commented Jul 18, 2023

Description

Add initial autoResize to support e.g. defaultValue or value

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Jul 18, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @monteri!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 84c0780
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64ba79e338be2400086a7155
😎 Deploy Preview https://deploy-preview-2453--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@monteri monteri added raccoon-gang and removed blended PR is managed through 2U's blended developmnt program labels Jul 18, 2023
@monteri monteri self-assigned this Jul 18, 2023
@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented Jul 20, 2023

@monteri do we need to fix the test?

@viktorrusakov
Copy link
Contributor

@PKulkoRaccoonGang we do 🙂

@monteri please update the failing test, judging by the test case I'm pretty it broke because now you call handleResize after first render instead of only as a onChange handler.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Jul 21, 2023
@monteri
Copy link
Contributor Author

monteri commented Jul 21, 2023

Fixed tests

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d55001f) 91.38% compared to head (84c0780) 91.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2453   +/-   ##
=======================================
  Coverage   91.38%   91.39%           
=======================================
  Files         234      234           
  Lines        4157     4161    +4     
  Branches     1001     1001           
=======================================
+ Hits         3799     3803    +4     
  Misses        351      351           
  Partials        7        7           
Impacted Files Coverage Δ
src/Form/FormControl.jsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamstankiewicz adamstankiewicz merged commit be5cf27 into openedx:master Jul 21, 2023
9 checks passed
@openedx-webhooks
Copy link

@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.45.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

pedromartello pushed a commit to hammerlabs-net/paragon that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program raccoon-gang released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants