-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: initial autoResize functionality #2453
[BD-46] fix: initial autoResize functionality #2453
Conversation
Thanks for the pull request, @monteri! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@monteri do we need to fix the test? |
@PKulkoRaccoonGang we do 🙂 @monteri please update the failing test, judging by the test case I'm pretty it broke because now you call |
Fixed tests |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2453 +/- ##
=======================================
Coverage 91.38% 91.39%
=======================================
Files 234 234
Lines 4157 4161 +4
Branches 1001 1001
=======================================
+ Hits 3799 3803 +4
Misses 351 351
Partials 7 7
☔ View full report in Codecov by Sentry. |
@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 20.45.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Add initial autoResize to support e.g.
defaultValue
orvalue
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist